Changeset 1065 for plugins/apostrophePlugin/trunk/lib/navigation/aNavigationAccordion.class.php

Timestamp:

04/26/10 17:08:58 (2 years ago)

Author:

tboutell

Message:

New default behavior of navigation components is appropriate for use on large sites with many pages. On small sites it may be slightly slower, in which case you can set app_a_many_pages to false to get the old "fetch the entire page tree and reuse it in each navigation component as needed" behavior back. This worked quite well up to about 1,000 pages but became a serious problem on an 8,000-page site.

aPage::getAncestorsInfo now has an optional 'includeSelf' parameter which defaults to false for backwards compatibility.

aPage::getInfo provides a page info array about the current page. Useful when merging information from the Info methods with information about pages you already have as objects.

aPage::getAccordionInfo now has an optional final parameter, 'root', which specifies the slug of the root page of the accordion tree. The page on which getAccordionInfo is called should be a descendant of that page (or the root page itself).

Files:

• plugins/apostrophePlugin/trunk/lib/navigation/aNavigationAccordion.class.php (modified) (2 diffs)

plugins/apostrophePlugin/trunk/lib/navigation/aNavigationAccordion.class.php

@@ -4 +4 @@
 {
   protected $cssClass = 'a-nav-item'; 
-  public function buildNavigation()
+  public function initializeTree()
   {
-    $this->rootInfo = parent::$hash[$this->root];
-    $this->activeInfo = parent::$hash[$this->active];
-    if(isset($this->rootInfo['children']))
+    if (sfConfig::get('app_a_many_pages', true))
     {
-      $this->nav = $this->rootInfo['children'];
+      // The use of the static sitewide page tree 
+      // requires too much memory on sites with more
+      // than about 500-1000 pages. On smaller sites
+      // it turns out to be a performance win to get
+      // all of the page information for the site and
+      // cache it for subsequent navigation elements on
+      // the same page, which the base class does for us
     }
     else
     {
-      $this->nav = $this->rootInfo['parent']['children'];
+      parent::initializeTree();
     }
+  }
+  public function buildNavigation()
+  {
+    if (sfConfig::get('app_a_many_pages', true))
+    {
+      $activePage = aPageTable::retrieveBySlug($this->active);
+      $this->activeInfo = $activePage->getInfo();
+      $this->rootInfo = $activePage->getAccordionInfo(false, null, $this->root);
+      // This rootInfo is already an array of kids
+      $this->nav = $this->rootInfo;
+    }
+    else
+    {
+      $this->rootInfo = parent::$hash[$this->root];
+      $this->activeInfo = parent::$hash[$this->active];
+      // This rootInfo is an individual page info
+      $this->nav = $this->rootInfo['children'];
+    }
+    // We no longer try to special case the situation where the root page has no children,
+    // because the active page should always be a descendant of the root page, and it
+    // complicated the implementation
     $this->traverse($this->nav);
   }
@@ -26 +51 @@
       $this->applyCSS($tree, $node);
       
-      if(!self::isAncestor($node, $this->activeInfo) && !($node['id'] == $this->activeInfo['id']))
+      // This is redundant if we used getAccordionInfo, and it won't work because we
+      // never set activeInfo or the 'parent' pointers
+      if (!sfConfig::get('app_a_many_pages', true))
       {
-        unset($node['children']);
+        if(!self::isAncestor($node, $this->activeInfo) && !($node['id'] == $this->activeInfo['id']))
+        {
+          unset($node['children']);
+        }
       }