To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Show
Ignore:
Timestamp:
09/07/10 17:08:36 (21 months ago)
Author:
tboutell
Message:

Fixed #428 (you can no longer reorder in an area while it has an unsaved new slot) and greatly sped up the move arrows. They now work on the client side without waiting for the site to refresh the area.

Refactored the JavaScript? associated with the up and down arrows.

Fixed a previously unnoticed bug: a-new-slot wasn't getting cleared when a slot was saved.

TODO: strip down the response from the server to a yea or a nay.
TODO: actually do something about a nay (like refreshing the area).

Files:
1 modified

Legend:

Unmodified
Added
Removed

  • plugins/apostrophePlugin/trunk/modules/a/templates/_ajaxUpdateSlot.php

    r1964 r2144  
    99  $validationData = isset($validationData) ? $sf_data->getRaw('validationData') : null; 
    1010  $variant = isset($variant) ? $sf_data->getRaw('variant') : null; 
     11  $slot = isset($slot) ? $sf_data->getRaw('slot') : null; 
    1112?> 
    1213<?php // 1.3 and up don't do this automatically (no common filter) ?> 
    … …  
    1819<?php use_helper('a') ?> 
    1920<?php a_slot_body($name, $type, $permid, $options, $validationData, $editorOpen, true) ?> 
     21<?php if (!$slot->isNew()): ?> 
     22  <?php a_js_call('apostrophe.slotNotNew(?, ?, ?)', $pageid, $name, $permid) ?> 
     23<?php endif ?> 
     24<?php a_js_call('apostrophe.areaUpdateMoveButtons(?, ?, ?)', url_for('a/moveSlot'), $pageid, $name) ?> 
    2025<?php a_include_js_calls() ?> 
    2126<?php if (isset($variant)): ?>