Changeset 4517

Timestamp:

01/26/12 07:52:57 (4 months ago)

Author:

tboutell

Message:

Preserve slideshow order. Thanks to metadan. relinkMediaItems now returns the valid ids in order.

Files:

• plugins/apostrophePlugin/branches/1.5/lib/action/BaseaSlideshowSlotActions.class.php (modified) (3 diffs)

plugins/apostrophePlugin/branches/1.5/lib/action/BaseaSlideshowSlotActions.class.php

@@ -26 +26 @@
     {
       $ids = preg_split('/,/', $request->getParameter('aMediaIds'));
-      $this->relinkMediaItems($ids);
+      $links = $this->relinkMediaItems($ids);
 
       // This isn't a normal form submission, but the act of selecting items for a
@@ -46 +46 @@
    * Drop any existing links to media items and re-link to any valid media item ids
    * mentioned in $ids. Doctrine is not very good at this, but this solution is
-   * battle-tested
+   * battle-tested. Return the valid ids in order
    */
   protected function relinkMediaItems($ids)
@@ -56 +56 @@
     $links = aArray::getIds($items);
     $this->slot->link('MediaItems', $links);
+    return $links;
   }