Changeset 4541

Timestamp:

02/03/12 15:55:26 (4 months ago)

Author:

tboutell

Message:

Don't cache non-200 OK responses, it leads to SEO problems

Files:

• plugins/apostrophePlugin/branches/1.5/lib/sfFilter/aCacheFilter.class.php (modified) (1 diff)

plugins/apostrophePlugin/branches/1.5/lib/sfFilter/aCacheFilter.class.php

@@ -42 +42 @@
     {
       $filterChain->execute();
+      // Never try to cache a 404 error. Later we might consider
+      // caching them but remembering their status properly so it 
+      // doesn't magically become a 200 OK when returned from cache
+      if ($this->context->getResponse()->getStatusCode() !== 200)
+      {
+        return;
+      }
       $content = $this->context->getResponse()->getContent();
       // Check whether aCacheInvalid was set for this user during the current request, don't cache