To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #1217 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

[PATCH] Fix aSlideshowSlot not retaining slide order

Reported by: metadan Owned by: tboutell
Priority: minor Milestone:
Component: apostrophePlugin Version: 1.5
Keywords: media slideshow Cc:
Symfony version: 1.4

Description

When saving aSlideshowSlots currently the slides are not retaining the order they have been saved in.

This is to do with a refactoring that leaves a local variable inaccessible in revision 4484

Attachments

BaseaSlideshowActions.class.php.patch.diff Download (0.9 KB) - added by metadan 4 months ago.
apostrophePlugin\lib\action\BaseaSlidehsowActions?.class.php diff patch

Change History

Changed 4 months ago by metadan

apostrophePlugin\lib\action\BaseaSlidehsowActions?.class.php diff patch

Changed 4 months ago by tboutell

  • status changed from new to closed
  • resolution set to fixed

Good catch, thanks. I am now returning the valid ids in order from relinkMediaItems instead of setting $this->links. The fix is tested.

Note: See TracTickets for help on using tickets.