To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #153 (new defect)

Opened 2 years ago

Last modified 15 months ago

Slot params should be easier to pass around

Reported by: geoffd Owned by: dordille
Priority: minor Milestone: 2.0
Component: apostrophePlugin Version: 1.0
Keywords: Cc: boutell, agilbert, johnnyoffline
Symfony version: 1.4

Description

Opened by Alex Gilbert 4/28/2009 2:31 PM

When trying to add more complex functionality to a CMS slot, there is frequently the need to use setup, editSetup and editSave methods inside custom actions. These all require a set of parameters than can be easy to forget and verbose to use:

'after' => 'pkContextCMSBanner/attach?'.http_build_query(array(

'slug' => $slug,
'slot' => $name,
'permid' => $permid,
'noajax' => true,

))

It would be better to have them refactored somehow, perhaps into the slot object:

$this->slotParams = array(

'slug' => $this->slug,
'slot' => $this->name,
'permid' => $this->permid,
'noajax' => true,

);

Something like this:

'after' => 'pkContextCMSBanner/attach?'.http_build_query($slot->getParams()))

Change History

Changed 15 months ago by geoffd

  • milestone changed from 1.5 to 2.0
Note: See TracTickets for help on using tickets.