To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #252 (closed defect: fixed)

Opened 22 months ago

Last modified 22 months ago

Automatically include aBlog.css and aBlog.js into a project if blogs are enabled

Reported by: stephenrs Owned by: dordille
Priority: critical Milestone: 1.4
Component: apostropheBlogPlugin Version: trunk
Keywords: lab-day Cc: hillerj, rickybanister, geoffd, agilbert, dordille, johnnyoffline,
Symfony version: 1.4

Description

The checkAndSetPublish() function is defined in /js/aBlog.js, but aBlog.js is never explicitly included by the plugin, causing aBlogAdmin to malfunction - due to the call to the function in /modules/aBlogAdmin/templates/_optionsform.php.

According to changeset:887 aBlog.js should be added to view.yml, but it seems to me that the plugin should include it out of the box, perhaps as part of the other dependencies loaded in _assets.php.

Note: adding the file to view.yml does in fact make the error go away.

Change History

Changed 22 months ago by johnnyoffline

Stephen is right, I'm not sure of the best place to include the blog assets whether they are permanent or temporarily required until it's absorbed into the main plugin.

Right now our client sites that plan on using the plugin explicitly include the assets in view.yml

Changed 22 months ago by johnnyoffline

  • summary changed from Javascript error triggered by missing function checkAndSetPublish to Automatically include aBlog.css and aBlog.js into a project if blogs are enabled

Changed 22 months ago by johnnyoffline

  • keywords lab-day added

Changed 22 months ago by johnnyoffline

  • priority changed from major to critical

Changed 22 months ago by johnnyoffline

  • cc hillerj, rickybanister, geoffd, agilbert, dordille, johnnyoffline, added
  • milestone set to 1.1

Changed 22 months ago by dordille

  • status changed from new to closed
  • resolution set to fixed

Fixed in [982]

Note: See TracTickets for help on using tickets.