Apostrophe Should Validate

[geoffd]

Currently, punkave.com is not validating:

 http://validator.w3.org/check?uri=http://www.punkave.com/&charset=(detect+automatically)&doctype=Inline&group=0

We should make sure that Apostrophe validates. Make sure you apply all fixes to plugin and punkave.com

[boutell]

John I anticipate that some of these violations are probably my fault. Don't be afraid to rope me in on this one.

There is also the arg_separator problem. When it is set to & link_to output is compliant but redirects are invalid and they break. When it is set to & redirects work but link_to is noncompliant. We need to explore this issue and figure out if there's a plan in the Symfony community to fix it in a sensible way.

I think the whole "set arg_separator to &" thing is wrongheaded. & is correct *in a URL*, the URL should be *escaped after that* when it is output as an attribute in a link tag. If it isn't going into a link tag it shouldn't get escaped. Using & in the first place is a dumb band-aid like the old auto addslashes thing.

[johnnyoffline]

Happy to dig through this after the blog plugin is closer to completion and we start slaying some of these client sites that are hanging around.

I've already gone through an cleaned up our javascript somewhat to help with validation.

And JS that has markup in it needs to have the CDATA thing wrapped around it.

Also, we should switch all of our sites to the same doctype tag so the work we do with Validation has the same effects across the board.

Tom: Until recently, we were using the Transitional doctype tag. If we validate for the Strict doctype, will that imply validation with Transitional? I would hope so.

[boutell]

We probably won't hit this 100% for 1.4 but I still want John to try validating to see if it flushes any serious bugs out of the woodwork. We're not fixing arg_separator today.

[johnnyoffline]

FCK still seems to output <br> tags instead of <br/> tags.

URLS in FCK with the ampersand also crap the boat.

My pages are validation for the most part when there aren't any richtext slots on the page with user generated content.

[tboutell]

So our HTML simplifier is not fixing those br tags in rich text slots?

The ampersand is going to take a while to fix in various places.

[johnnyoffline]

It seems like FCK is lying to us regarding the BR tags. When you view source via FCK everything looks good. But it's just not true.

FCK View Source

Same code via Firebug

Same code via Browser View Source

And HTML Validators report the error so something is definitely up.

[johnnyoffline]

Tom,

For all intents and purposes Apostrophe does validate. I'm assigning this ticket to you because I believe the issue with the <BR/> tag and FCK is either a problem with FCK or a problem with the HTML cleaning that we do upon save.

One or the other incorrectly stores <BR/> as <BR>.

[geoffd]

Closed as duplicate. We just need to address the BR tag issue.