To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #296 (closed defect: fixed)

Opened 22 months ago

Last modified 15 months ago

sfWidgetFormJQueryDate.class.php exists in apostrophePlugin AND sfFormExtraPlugin

Reported by: agilbert Owned by: tboutell
Priority: critical Milestone: 1.5
Component: apostrophePlugin Version: trunk
Keywords: 1.5rc2 Cc: dordille, johnnyoffline
Symfony version: 1.4

Description

 http://trac.apostrophenow.org/browser/plugins/apostrophePlugin/trunk/lib/widget/sfWidgetFormJQueryDate.class.php

 http://trac.symfony-project.org/browser/plugins/sfFormExtraPlugin/branches/1.3/lib/widget/sfWidgetFormJQueryDate.class.php

This has the potential to cause conflicts for those who are using both plugins in a single project. Was this an intentional effort to override the widget in sfFormExtraPlugin or just an oversight? Could we possibly re-prefix our widget?

Change History

Changed 22 months ago by boutell

  • milestone changed from 1.2 to 1.1

Yes, we should hit this. I could've sworn this wasn't actually in the extras plugin, maybe it was added after I checked. It's fine to hit this in the current trunk, we'll need to fix usages in our current projects obviously, but we should stop the bleeding on this sooner rather than later

Changed 22 months ago by boutell

  • status changed from new to accepted

Changed 21 months ago by boutell

  • milestone changed from 1.4 to 1.5

Changed 17 months ago by tboutell

  • owner changed from boutell to tboutell

Changed 15 months ago by geoffd

  • keywords 1.5rc2 added
  • priority changed from major to critical

Tom, check to see if this is done.

Changed 15 months ago by tboutell

It's not done.

Bummer.

Changed 15 months ago by tboutell

  • status changed from accepted to closed
  • resolution set to fixed

This is done in [2696]

Changed 15 months ago by tboutell

It will be necessary to update project level code that references these widgets:

sfWidgetFormJQueryDate
sfWidgetFormJQueryTime
sfWidgetFormJQueryDateTime
sfWidgetFormJRichTextarea

To use the 'a' prefix instead of 'sf'. Pretty simple.

Note: See TracTickets for help on using tickets.