To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #316 (closed defect: fixed)

Opened 21 months ago

Last modified 21 months ago

I made some blog posts, how do I edit their titles / delete them / etc.?

Reported by: boutell Owned by: dordille
Priority: critical Milestone: 1.4
Component: apostropheBlogPlugin Version:
Keywords: Cc: geoffd, agilbert, johnnyoffline
Symfony version: 1.4

Description

Okay, now I have blog posts... I can edit their content slots... but I can't edit their titles or delete them or figure out where I'm supposed to go to do this.

Aha, it's because I'm not in /admin/blog. Okay, so I click on Blog and go there. Yes, it looks like I can edit the metastuff here.

We should ditch the in-place editing of blog posts on blog engine pages and just attach edit buttons to the blog posts which take you to the admin blog page where you're allowed to really do it. Ditto for in-place editing of blog posts in blog slots, if that is currently allowed. It's wayyyy too confusing to have half the editing features and no link to the other half.

Hey, it's interesting that I don't seem to need a /admin/blog engine and in fact I'm just now realizing that you don't have one at all. But I do need *a blog engine page* somewhere on the site, which is why my first attempt to create a blog post failed, right? We still need to document that issue and provide some kind of task to get that page created, working around the problem of not being able to merge nested set fixtures from two plugins. I'll update my other tickets.

Change History

Changed 21 months ago by dordille

Tom I agree that we should probably ditch in-place editing on engine pages. One issue that will need to be addressed in order to handle this is having the edit => false option also apply to admin users as well as editors.

Changed 21 months ago by boutell

True. Assign me a ticket please?

Changed 21 months ago by dordille

  • status changed from new to closed
  • resolution set to fixed

This has been fixed by disable editing on engine pages. [1180]

Changed 21 months ago by geoffd

I thought editing blog posts in engine pages was one of the cool new features of the blog plugin?

Why are we giving up on that?

Changed 21 months ago by boutell

Geoff, the blog plugin was designed from the get-go to use a traditional Symfony admin generator module for managing blog entries, and an engine module only for public presentation. The editability of blog post bodies in the engine was a side effect (because they are Apostrophe areas), not an intended feature.

I would have preferred the approach we took in the media repository - it's always the same engine module, there's an admin-only version of it as well as potentially some public ones. But Dan and crew did some very cool things with the admin generator in terms of being able to manage blog posts. I think it's okay as long as those who do have admin features can easily recognize how to get to the admin side.

Changed 21 months ago by geoffd

Keep in mind that we intend to allow people to edit data fields in the grid view of media in the future. Similar to how Flickr handles that.

This ability to edit in context is something that we should bring back in future releases.

Changed 21 months ago by johnnyoffline

Geoff, I agree with you 100%.

There are two issues at hand with allowing editing right now.

First issue: When the engine page loads, every richtext slot stuffs in an iframe after the dom is ready.

That makes the experience browsing the engine page horrible when logged in.

What needs to happen, the Richtext editor needs to instantiate it's iframe when the user clicks the Edit button, paying that loading penalty when they want to actually manipulate a piece of content, instead of EVERYTIME the page loads.

Tom is aware of this one, but I'm not sure if there's a ticket.

The second issue:

We have a page sprinkled to high heaven with buttons everywhere.

SO if we create that edit in place functionality for the media library, whatever the lexicon we use for that could carry over to editing blogs in the engine view.

It could even be like how Jake has the buttons hidden in DarienSt?

Changed 21 months ago by boutell

This is all true. A third point is that unlike the media repository's setup, the blog engine is not the canonical best and most featureful place to edit the blog. I think we should be careful about allowing in context editing unless you can get *all* of it done. It's very easy to get confused and think "this is it, there is no more functionality, oh well it can't do what I want."

Note: See TracTickets for help on using tickets.