To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #36 (closed defect: fixed)

Opened 2 years ago

Last modified 21 months ago

Global Slots still editable in Admin Generator pages

Reported by: johnnyoffline Owned by: dordille
Priority: major Milestone: 1.4.1
Component: apostrophePlugin Version: 0.9.3
Keywords: ui Cc: rickybanister, johnnyoffline, hillerj, boutell, dordille
Symfony version:

Description (last modified by johnnyoffline) (diff)

Opened by Rick Banister 9/16/2009 12:39 PM
Tom,

We had a problem a while back that apparently never got fixed. At least not fixed in cmstext. The global footer slot is still editable in the media section, user section, etc.

If you are on an engine page, it should still be editable, but not an admin page.

Assigned to Dan Ordille by Rick Banister 12/2/2009 12:02 PM
Dan,

See if this one makes sense to you, let me know if you have any questions.

Assigned to Rick Banister by Dan Ordille 12/4/2009 4:31 PM
I think this would should fixed by specifying a different layout for the admin generator to use.

Assigned to John Benson by Rick Banister 12/10/2009 11:46 AM
what do you think about this?

Assigned to Tom Boutell by John Benson 12/17/2009 5:24 PM

pkContextCMSTools::setAllowSlotEditing(false);

Check the screenshot. this is the actionsClass that has the call in it.

actions.class.php

It's ignored in all adminGenerated pages

(like Users module etc)

and it's been this way for as long as i can recall

Attachments

file-tree.png Download (19.3 KB) - added by johnnyoffline 2 years ago.
actions.class.php

Change History

Changed 2 years ago by johnnyoffline

actions.class.php

Changed 2 years ago by johnnyoffline

  • description modified (diff)

Changed 2 years ago by agilbert

  • sensitive set to 0
  • version changed from Symfony 1.4 to 0.9.3
  • milestone set to 1.1

Changed 23 months ago by boutell

  • status changed from new to accepted

I think I should refuse to render edit views at all when there is no current page, and say that those who want them should be using an engine. I'm thinking here of the fact that there might be nowhere to safely redirect the user to after something like an image selection.

Changed 21 months ago by johnnyoffline

  • owner changed from boutell to dordille
  • status changed from accepted to assigned
  • milestone changed from 1.4 to 1.4.1

Dan, I think you already fixed this recently even.

I made this 1.4.1 but If you can confirm that this is resolved then give it to Rick so he can verify

that would be super

Changed 21 months ago by dordille

  • status changed from assigned to closed
  • resolution set to fixed

This has been fixed now that we have new functionality elsewhere. By setting the edit option to false in your templates you can disable editing, if this is combined with our ability to now if the page exists give us a solution. For example

<?php $edit = isset($page)? true : false; ?>
  <?php a_area('footer-links', array(
     'global' => true,
     'edit' => $edit,
     'allowed_types' => array('aButton'),
     )); ?>

Changed 21 months ago by agilbert

psst this works too

  <?php a_area('footer-links', array(
     'global' => true,
     'edit' => isset($page) ? true : false,
     'allowed_types' => array('aButton'),
     )); ?>
Note: See TracTickets for help on using tickets.