To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #360 (closed enhancement: fixed)

Opened 21 months ago

Last modified 16 months ago

Implement a global category & tag editor

Reported by: rickybanister Owned by: johnnyoffline
Priority: critical Milestone: 1.5
Component: apostrophePlugin Version: trunk
Keywords: 1.5b Cc: dordille, boutell, agilbert, geoffd, johnnyoffline
Symfony version: 1.4

Description (last modified by rickybanister) (diff)

Design for a global tag editor:

Tag names should be highlighted yellow like slugs. Clicking them makes it become a text field with mini save/cancel buttons.
Cascade delete all tag instances
Merge two tags together by renaming one to be the other (show a confirm message)
Edit tag name + cascade the change to tagged objects
View how many posts use the tag

If a slot is pulling posts by tag and the tag changes, that slot should not break, but get the new tag name. Slots should be set by tag id maybe.

Other thoughts: perhaps we should include redundant interfaces (batch merge all checked tags, add a merge button--merge the first clicked tag with the second clicked tag)


Attachments

Screen shot 2010-05-17 at 3.36.42 PM.png Download (198.0 KB) - added by geoffd 21 months ago.
Screen shot 2010-05-17 at 3.36.45 PM.png Download (169.7 KB) - added by geoffd 21 months ago.
tag-admin.png Download (0.7 MB) - added by rickybanister 21 months ago.
Screen shot 2010-09-07 at 12.06.42 PM.png Download (47.8 KB) - added by geoffd 17 months ago.

Change History

Changed 21 months ago by geoffd

Changed 21 months ago by geoffd

  Changed 21 months ago by geoffd

  • description modified (diff)

  Changed 21 months ago by boutell

Note to whoever winds up implementing it: the rename functionality should recognize the case where you're implicitly merging it into another existing tag and react gracefully.

  Changed 21 months ago by rickybanister

  • owner changed from rickybanister to dordille
  • status changed from new to assigned
  • description modified (diff)

Changed 21 months ago by rickybanister

  Changed 21 months ago by rickybanister

  • description modified (diff)

  Changed 21 months ago by johnnyoffline

We are doing all three merge interfaces.

1. Implicit renaming brings up a merge prompt
2. Hovering the Row brings up a merge button (clicking 1 merge button and then a second merge buttong brings up a prompt
3. Batch merge is in the bulk options

  Changed 21 months ago by geoffd

Doing #2 above (Hovering the Row brings up a merge button (clicking 1 merge button and then a second merge buttong brings up a prompt ) seems overly complicated and unnecessary.

I don't think we should do that in this round. If we discover that we need another way to merge tags, we can add it later.

  Changed 21 months ago by rickybanister

I suppose the first of the three we should implement is the batch merge action. All the bits are already built in.

  Changed 21 months ago by rickybanister

  • milestone set to 1.4

  Changed 21 months ago by rickybanister

  • milestone changed from 1.4 to 1.5

  Changed 21 months ago by dordille

  • component changed from apostropheBlogPlugin to apostrophePlugin

  Changed 20 months ago by dordille

If a slot is pulling posts by tag and the tag changes, that slot should not break, but get the new tag name. Slots should be set by tag id maybe. 

I don't like imposing behavior on plugins like the blog plugin. I think the best method to do this would be to use symfony events. When a tag is renamed have an sfEvent dispatched then any plugin or component that wants to deal with can in their own way.

  Changed 20 months ago by boutell

Yeah, I'm not convinced this is necessary or a good idea all in all. If you want formality use categories

  Changed 17 months ago by rickybanister

  • keywords 1.5rc added
  • version set to trunk

There's been a lot of discussion on this ticket. For now, all we want to do is duplicate the category admin exactly. Allow merging by renaming one tag to another.

follow-up: ↓ 15   Changed 17 months ago by geoffd

Currently, the category admin looks like this:

Error: Macro Image(Screen shot 2010-09-07 at 12.06.42 PM) failed
Attachment 'ticket:360: Screen shot 2010-09-07 at 12.06.42 PM' does not exist.

We need to add an actions column at the end with Edit and Delete buttons.

We also should add a way to switch between Categories and Tags when viewing either. Maybe a drop down at the top? A pill button? Some snazzy buttons?

Changed 17 months ago by geoffd

in reply to: ↑ 14   Changed 17 months ago by geoffd

Replying to geoffd:

Currently, the category admin looks like this:



We need to add an actions column at the end with Edit and Delete buttons.

We also should add a way to switch between Categories and Tags when viewing either. Maybe a drop down at the top? A pill button? Some snazzy buttons?

  Changed 17 months ago by tboutell

Tags are used for:

Posts
Events
Pages (new in 1.5)

If we're going to show counts, show the count for pages too.

There will also be project-specific uses of tags for other model classes, and we could support adding more count columns rather easily via app.yml (we actually did this back before Apostrophe). We probably should, because otherwise when you go to administer tags you will see confusing results (if it's not used for anything, why is it here?).

  Changed 17 months ago by rickybanister

  • priority changed from major to critical

  Changed 17 months ago by tboutell

  • type changed from defect to enhancement

  Changed 17 months ago by Dana

  • summary changed from Implement a global tag editor to Implement a global category & tag editor

  Changed 16 months ago by geoffd

Dan, when you are done with your part, assign this to Rick to implement the design to switch between the categories and tags.

  Changed 16 months ago by dordille

  • owner changed from dordille to rickybanister

Rick the tag admin is in place. The url is admin/tags.

  Changed 16 months ago by geoffd

  • owner changed from rickybanister to johnnyoffline

Rick, come up with design for how to switch between tag and category editor

  Changed 16 months ago by tboutell

  • owner changed from johnnyoffline to dordille

This is now accessible in the sandbox via the new "Tags" button (it's possible to change the appearance of the buttons to sorta-merge them per Rick's design if you override the globalButtons partial for a project, and that's been made really easy to do, so don't worry overmuch if the two buttons seem excessive to you)

* * *

Dan, there is a bug: I tried to rename a tag and got this...

Call to undefined method aTagAdminActions::setFlash., referer:  http://demotrunk/admin/tags/5/edit

I renamed the tag to match another tag so they would merge, I don't know if that matters or not.

Reassigned to Dan for debugging.

  Changed 16 months ago by geoffd

  • keywords 1.5b added; 1.5rc removed

  Changed 16 months ago by dordille

  • owner changed from dordille to johnnyoffline

John I fixed the bug on my end, reassigning to you since you had it before me, you can close if everything else is good.

  Changed 16 months ago by johnnyoffline

  • status changed from assigned to closed
  • resolution set to fixed

[2566]

Styled

Note: See TracTickets for help on using tickets.