To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #430 (closed defect: fixed)

Opened 20 months ago

Last modified 13 months ago

doctrine:clean going crazy!

Reported by: agilbert Owned by: tboutell
Priority: major Milestone: 1.5
Component: apostrophePlugin Version: 1.5
Keywords: 1.5rc2 Cc: dordille
Symfony version: 1.4

Description

Check this out:

hackworth:cs alex$ svn status
X       plugins/sfSyncContentPlugin
X       plugins/sfDoctrineActAsTaggablePlugin
X       plugins/sfJqueryReloadedPlugin
X       plugins/sfWebBrowserPlugin
X       plugins/sfFeed2Plugin
X       plugins/sfDoctrineGuardPlugin
X       plugins/apostrophePlugin
X       plugins/apostropheBlogPlugin
X       plugins/sfTaskExtraPlugin
!       lib/form/doctrine/apostrophePlugin/aSlideshowSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aVideoSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aAreaForm.class.php
!       lib/form/doctrine/apostrophePlugin/aPDFSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aButtonSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aAreaVersionForm.class.php
!       lib/form/doctrine/apostrophePlugin/aLuceneUpdateForm.class.php
!       lib/form/doctrine/apostrophePlugin/aAreaVersionSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aRawHTMLSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aImageSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aMediaBrowserSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aTextSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaAreaForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaVideoSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaPDFSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaButtonSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaLuceneUpdateForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaAreaVersionForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaRawHTMLSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaAreaVersionSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaImageSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaMediaBrowserSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaTextSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaRichTextSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/base/BaseaSlideshowSlotForm.class.php
!       lib/form/doctrine/apostrophePlugin/aRichTextSlotForm.class.php
!       lib/filter/doctrine/apostrophePlugin/aRichTextSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aSlideshowSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aAreaFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aVideoSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aPDFSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aButtonSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aLuceneUpdateFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aAreaVersionFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aRawHTMLSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aAreaVersionSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aImageSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaSlideshowSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaVideoSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaAreaFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaPDFSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaButtonSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaAreaVersionFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaLuceneUpdateFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaAreaVersionSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaRawHTMLSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaImageSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaMediaBrowserSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaTextSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/base/BaseaRichTextSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aMediaBrowserSlotFormFilter.class.php
!       lib/filter/doctrine/apostrophePlugin/aTextSlotFormFilter.class.php
Performing status on external item at 'plugins/apostrophePlugin'
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaImageSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaMediaBrowserSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaTextSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaRichTextSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaSlideshowSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaVideoSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaAreaForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaPDFSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaButtonSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaLuceneUpdateForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaAreaVersionForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaRawHTMLSlotForm.class.php
!       plugins/apostrophePlugin/lib/form/doctrine/PluginaAreaVersionSlotForm.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaPDFSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaButtonSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaLuceneUpdateFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaAreaVersionFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaRawHTMLSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaAreaVersionSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaImageSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaMediaBrowserSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaTextSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaRichTextSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaSlideshowSlotFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaAreaFormFilter.class.php
!       plugins/apostrophePlugin/lib/filter/doctrine/PluginaVideoSlotFormFilter.class.php

I ran doctrine:clean after updating my symfony checkout and this is what happens.

Maybe this is OK / intentional? But if these files aren't needed, we should clean them up so that other developers who need to clean their own model files don't have to deal with it.

Change History

Changed 19 months ago by tboutell

  • owner changed from tboutell to agilbert
  • status changed from new to assigned

This looks right to me. As I recall Dan learned about the schema.yml options to turn off form and filter classes you don't need, and added them to schema.yml, but I guess nobody ran doctrine:clean in the sandbox after that.

Please verify that the sandbox is happy after doctrine:clean and then go ahead and commit in the sandbox.

Changed 13 months ago by geoffd

  • keywords 1.5rc2 added
  • owner changed from agilbert to tboutell
  • version changed from 1.4 to 1.5
  • milestone changed from 1.4.2 to 1.5

Tom, please check that this was done in Sandbox and it is happy.

Changed 13 months ago by tboutell

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [3180] and [3182]

We had quite a few as-yet-uncleaned classes

Note: See TracTickets for help on using tickets.