To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #463 (closed defect: fixed)

Opened 20 months ago

Last modified 17 months ago

Merge my 'editors and managers can't see page settings' fix to trunk

Reported by: tboutell Owned by: johnnyoffline
Priority: major Milestone: 1.5
Component: apostrophePlugin Version: trunk
Keywords: admin, ui Cc: rickybanister, agilbert
Symfony version: 1.4

Description

See:

 http://trac.apostrophenow.org/changeset/1618

Looks like conflict city over in trunkland. Please apply this fix by hand based on your knowledge of the new page settings stuff in the trunk. Be sure to determine who is allowed to edit only once, setting a variable as I have done.

Change History

Changed 19 months ago by johnnyoffline

  • owner changed from johnnybenson to johnnyoffline
  • status changed from new to assigned

Changed 17 months ago by johnnyoffline

Tom,

This ticket is two months old, has this fix found its way into the trunk or should I look into bringing this over?

Changed 17 months ago by tboutell

It is two months old and not a whit further advanced than it was two months ago to my knowledge (:

See the diff for the correct way to determine who should have "this page" privileges.

Changed 17 months ago by johnnyoffline

  • status changed from assigned to closed
  • resolution set to fixed

I looked at your diff and two of the files already have the changes.

tookitRebuildIndexTask.class.php was previously updated

and a new _allPrivileges.php partial was created in the trunk, along with the changes that were done to the page privileges form.

I updated _globalTools to use the new logic around the 'Page Settings' button.

I would consider this migrated

Changed 17 months ago by johnnyoffline

[2121]

Note: See TracTickets for help on using tickets.