To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #489 (closed defect: fixed)

Opened 19 months ago

Last modified 18 months ago

Slideshow selection is duplicated when choosing images for slideshow slot

Reported by: spike Owned by: tboutell
Priority: major Milestone: 1.5
Component: apostrophePlugin Version: trunk
Keywords: cropping, media Cc: tboutell, geoffd, jake, agilbert
Symfony version: 1.4

Description

When you click "Choose Images" on a slideshow slot, the list of selected media items shows each item twice. I.e, if there are mediaItems 6 and 7 assigned to a particular slot, when choosing images, the multiplePreview list shows items 6, 7, 6, 7.

It turns out it's due to the foreach block at line 34 of BaseaSlideshowSlotComponents?.class.php; the $this->itemIds is populated twice.

Attachments

BaseaSlideshowSlotComponents.class.php.diff Download (507 bytes) - added by spike 19 months ago.
this should fix it

Change History

Changed 19 months ago by spike

This seems like it must be an issue for all slideshow slots in the trunk -- can this be confirmed?

Changed 19 months ago by spike

this should fix it

Changed 19 months ago by tboutell

Spike, can you just go ahead and do this in the cropping branch? Do you have any trouble committing there? I definitely want you to be able to commit there... especially some of that javascript stuff I haven't figured out yet

Changed 19 months ago by tboutell

  • owner changed from spike to tboutell
  • status changed from new to accepted

Oops this is of course not cropping branch related. Never mind.

Changed 19 months ago by tboutell

Let's fix the cropping branch and merge it, making this irrelevant

Changed 19 months ago by spike

Yep you bet I'll commit it (from an Airplane!)

Changed 18 months ago by tboutell

  • status changed from accepted to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.