Strip out FCK created empty elements <p>&nbsp;</p> at save()

[johnnyoffline]

Tom,

Can we get aHtml::simplify() to watch for and remove this specific scenario:

<element>&nbsp;</element>

Every single time I use FCK and hit return return delete delete type type type delete return, I am left with the above markup.

If I edited a heading the element will be an <Hx> tag.
Very often it's simply this:

<p>&nbsp;</p>

It creates accessibility issues according to webaim and it also just makes type layout look bad.

[tboutell]

FCK adds these because most of the browser rich text editors act completely crazy if you don't have this at the end of the document, btw. But stripping them out at save time should be possible yeah.

[geoffd]

This relates to ticket #494

[tboutell]

Implemented in [2975]:

Replace <p>&nbsp;</p> (generated by all the major browser RTEs, or possibly by FCK itself) with <br />.

There are other cases, like <h4>&nbsp;</h4> if you put a "blank line" between h4's, but I don't think we should change these because the visual impact of a br between two separte major heading elements is not the same as a "&nbsp; only" major heading element in between them. A deeper fix would be something like:

<h4>First line<br />Second line</h4>

But this change is not trivial to apply because we have to remove the closing and reopening of the neighboring h4's to merge them into one, and the styling of the site has to be written with the possibility of internal br's in headings in mind (often folks assume br won't appear in headings at all and give it a fixed height). More discussion is welcome.