To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #511 (closed defect: fixed)

Opened 18 months ago

Last modified 18 months ago

Fix single image slot in cropping branch

Reported by: tboutell Owned by: spike
Priority: major Milestone: 1.5
Component: apostrophePlugin Version:
Keywords: cropping, media Cc: spike, jake, johnnyoffline, geoffd
Symfony version: 1.4

Description

Spike says single image slots are borked in the cropping branch. Fix that so you can merge it to trunk and call it soup.

Change History

Changed 18 months ago by spike

  • owner changed from agilbert to spike
  • status changed from new to accepted

Changed 18 months ago by spike

  • status changed from accepted to closed
  • resolution set to fixed

Single image cropping is fixed. I broke it when I added aMediaTools::setDefaultCropDimensions(), which set the cropWidth parameter to 0 when aspectRatio == 0. Now cropping handles image(s) selection with *and* without aspectRatio set.

There is still some cleanup and possible refactoring to do, because _selectSingle.php is no longer used, and _selectMultiple.php has some hardcoded slideshow messaging. We will want to change the value of the "Save Slideshow" button, and also disable reordering of images in the preview when it's a single image selection. I'm going to refrain from making these bigger changes because I don't know what grand scheme you guys have in mind.

Also, I added some messaging to be I18Nized, so I imagine y'all will want to update the XLIFF translations. Clueless though as to how you approach I18N.

Note: See TracTickets for help on using tickets.