engine-slug option for aRoute and aDoctrineRoute should not require an additional query

[dordille]

aRoute and aDoctrineRoute both support the engine-slug option however this is impractical to use due to performance hits in fetching the corresponding engine every time a link is made.

From aRouteTools

static public function pushTargetEnginePage($page)
  {
    if (!(is_object($page) && ($page instanceof aPage)))
    {
      $page = aPageTable::retrieveBySlug($page);
    }
    self::$targetEnginePages[$page->engine][] = $page;
  }

addPageToUrl currently expects the targetEnginePages cache to be an array of objects. The solution seems to be to allow the $targetEnginePages cache accept slugs. For backwards compatibility with 1.4 the cache should also allow aPage objects.

[dordille]

Fixed in [2087].

aRouteTools::$targetEnginePages is now an array of page slugs instead of an array of pages.

[tboutell]

Awesome!

Is this merged?

[tboutell]

Does this allow you to implement your best-engine method?