To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #547 (closed enhancement: fixed)

Opened 18 months ago

Last modified 17 months ago

toolbar not display at all when not needed

Reported by: slithytove2 Owned by: johnnyoffline
Priority: minor Milestone:
Component: apostrophePlugin Version: trunk
Keywords: Cc:
Symfony version: 1.4

Description

If the user is not logged in and login_link is set to false, the toolbar still shows, but empty (and has a 2px height). It seems to me that if it will be empty, it should not show at all.

I just pulled ifs from inside the block. I'm not sure if isAuthenticated needs to be checked (would one of the first 3 return true if the user is authenticated?)

Attachments

_globalTools.php.diff Download (0.7 KB) - added by anonymous 18 months ago.

Change History

Changed 18 months ago by anonymous

Changed 18 months ago by agilbert

  • owner changed from agilbert to johnnyoffline
  • status changed from new to assigned

Changed 17 months ago by rickybanister

  • status changed from assigned to closed
  • resolution set to fixed

changed the name of the parameter to be this:

# false if you want to hide the global toolbar to logged-out visitors
persistent_global_toolbar: true

because login_link didn't really make sense.

Changed 17 months ago by rickybanister

[2293]
[2294]

Note: See TracTickets for help on using tickets.