aButtonSlot - Edit View Form Markup is not good

[johnnyoffline]

Tom,

I don't really recognize what's going on in this partial to break it up and use the correct apostrophe sanctioned form markup.

It's outputting the form without enough markup in the right places, causing formatting to look bunk.

Can you explain this to me:

<?php
  // Compatible with sf_escaping_strategy: true
  $form = isset($form) ? $sf_data->getRaw('form') : null;
?>
<?php use_helper('I18N') ?>
<?php if ($form['url']->hasError()): ?>
  <div class="a-error"><?php echo __('Invalid URL. A valid example: http://www.punkave.com/', null, 'apostrophe') ?></div>
<?php endif ?>
<div class="a-form-row"><?php echo __('URL: %r%', array('%r%' => $form['url']->render()), 'apostrophe') ?></div>
<div class="a-form-row"><?php echo __('Title: %t%', array('%t%' => $form['title']->render()), 'apostrophe') ?></div>
<?php echo $form->renderHiddenFields() ?>

bad markup

looks bunk

[tboutell]

Huh, interesting. I don't think I wrote this but I may have.

It's just an i18n'd version of:

<div class="blah">URL: <?php echo $formurl?->render() ?></div>

I guess the idea was that by putting the entire row in the () call you get the ability to swap the order of the label and the input element when translating, but this is not important right now.

You can junk it entirely (well, after the prologue that grabs $form), and start over from echo $form and you won't be missing anything important. Make sure the bogus-URL error looks reasonable however you do it.

[johnnyoffline]

I fixed this and the edit forms for the rest of our slots.

[2216]