To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #82 (accepted defect)

Opened 2 years ago

Last modified 13 months ago

Only Show Relevant Tags in Media Engines

Reported by: geoffd Owned by: tboutell
Priority: minor Milestone: 1.6
Component: apostrophePlugin: Media Version:
Keywords: Cc: dordille, agilbert, johnnyoffline, rickybanister
Symfony version: 1.4

Description

If you limit a Media Engine to certain categories, it should only show tags in the left column that relate to the media you can browse there.

Currently, it is showing you all tags (even if they are not associated with any photo, video, etc in that curated group.)

Attachments

Screen shot 2011-01-16 at 12.46.23 PM.png Download (387.7 KB) - added by geoffd 13 months ago.

Change History

Changed 2 years ago by geoffd

  • milestone set to 1.1

Changed 21 months ago by boutell

  • milestone changed from 1.4 to 1.4.1

Changed 17 months ago by tboutell

  • owner changed from boutell to tboutell

Changed 13 months ago by geoffd

  • keywords 1.5rc2 added
  • milestone changed from 1.4.2 to 1.5

I think this might be done. Please review.

Changed 13 months ago by tboutell

I did this and all of its related consequences pretty thoroughly to the ground - for blog and events, which are much more heavily used as engines. Media could really use a similar rewrite but I think we should let it go for 1.5. I'll check to make sure there isn't at least partial support already in there for this feature though

Changed 13 months ago by geoffd

  • summary changed from Only Show Relevant Tags in Engines to Only Show Relevant Tags in Media Engines

I just checked and this is not happening on Media. I agree that if this is not an easy fix, we should move the Media fix to 1.6.

Also, we should remove filters for PDFs, Audio, Office, etc if files that you have filtered a public media engine to do not exist.

Changed 13 months ago by johnnyoffline

How do you guys feel about not showing PDF audio office filters if none of those file types are in media at all?

Changed 13 months ago by geoffd

Good question.

In the media section, it might make sense to show them all so people know what is possible. As long as we have a good message that tells them that they can upload them, I think we are fine.

Changed 13 months ago by tboutell

I don't think you can filter a public media engine so that certain types of files can't exist. You can filter by categories, that's pretty much it.

Changed 13 months ago by johnnyoffline

Tom, I am just saying if there are zero PDFs in the media library, do not display the filter for PDFs. Geoff us saying it serves a sexoday purpose of suggesting what CAN exist. I'm fine with that if
There was a count next to the types...

Images (759)
Videos (57)
PDF (0)

Changed 13 months ago by geoffd

I think John's idea is a good one.

Take a look at this page:
 http://sandbox.apostrophenow.org/media/media-engine

You can see that there are A LOT of tags and none of them are helpful for the 11 photos in the 1 category I have limited it to.

Here is a screenshot:

Either way, if this is not a small adjustment we should move this to 1.6. It would nice for Media to be consistent with Blog and Events.

Changed 13 months ago by geoffd

Changed 13 months ago by tboutell

  • status changed from new to accepted

To hit this in a way that doesn't feel broken you pretty much have to port what I did for blog and events

None of our forthcoming 1.5 ports are overriding the media module, so there wouldn't be anything to rework there

Hmm.

Let me take a look and see if that code is straightforward to adapt to the media module.

Changed 13 months ago by tboutell

  • keywords 1.5rc2 removed
  • milestone changed from 1.5 to 1.6

No it is much too much. I got into it for a while and even set aside a diff to maybe look at in the 1.6 timeframe but we should not kick over this anthill for 1.5.

Changed 13 months ago by tboutell

To give you an idea, I would have to convince Alex to have someone else deal with CyberSource? and ignore all client projects for probably another full day to get this done right, and then there would probably be bugs that got dealt with by the usual "client projects break and Jake and John and Dana and Rick are stuck dealing with it" method. It's totally worth it but not now.

Would it be worth it to do a quick and dirty thing where tags got reduced in number according to the category and type filters but that was it? No accurate counts for the types taking into account the category, tag, search and image dimension criteria; no accurate counts for the categories taking into account the other filters; just cutting out the tags that don't match the allowed categories on the page and that's all. That would take maybe 2 hours. If that is the real pain point here then that might be an okay 80-20 thing for 1.5.

The good news is that we have a way better understanding of our filters and our schema that should really inform our work on 1.6 and/or 2.0, even if we haven't had a chance to impose perfection throughout 1.5

Note: See TracTickets for help on using tickets.