To participate you must create an account on apostrophenow.org. If you have already done so, click Login.

Ticket #84 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

JS errors in _globalTools.php partial (semicolons missing!)

Reported by: asaphosting Owned by: johnnyoffline
Priority: critical Milestone:
Component: apostrophePlugin Version:
Keywords: Cc:
Symfony version: 1.4

Description

The file is this one: plugins/apostrophePlugin/trunk/modules/a/templates/_globalTools.php

In line 75 and 86 semicolons are missing. :)

Daniel

PS: I think this is also in asandbox.

Change History

Changed 2 years ago by boutell

  • owner changed from boutell to johnnyoffline
  • status changed from new to assigned

John, did we hit this? If not how critical is it?

Changed 2 years ago by johnnyoffline

  • status changed from assigned to closed
  • resolution set to fixed

The missing semicolons were not causing any errors for me :D

But thanks for reporting them!

Committed revision 327.

Changed 2 years ago by boutell

Now that I've had a little sleep: semicolons are optional at end of line in javascript. It's not invalid syntax, not an error, definitely not a critical bug. But it is good form to include them.

Note: See TracTickets for help on using tickets.